tree 5d3e12277a9866da7b40fa9cf5405844648c8c6c
parent a06ba8611cee7f70fdb8e95d6c06d43309f2e783
author Oliver Newman <olivernewman@google.com> 1627933426 +0000
committer Oliver Newman <olivernewman@google.com> 1627933426 +0000

Add shim to set -property-only=true for led edit-recipe-bundle

This is a terrible hack to ensure that led jobs based on
property-versioned builds still run recipe_bootstrap, so the recipe gets
passed the expected properties. See the comment in update.sh for more
details.

I'm hoping we won't need to keep this around for more than a few months,
as LUCI folks have indicated they're interested in making
recipe-bootstrapping LUCI executables more of an official thing. That
would likely involve teaching led how to detect that a given build uses
a bootstrap luciexe, and to implicitly set -property-only=true for such
builds.

As mentioned in the comment, this will break `led edit-recipe-bundle`
for any builders where property versioning is not yet enabled, so I'll
wait until after property versioning is enabled on all builders before
landing this change.

Test to make sure it works:
1. Add a "modified by led" step at the beginning of fuchsia.py and
   build.py locally.
2. led get-build 8840251987610265761 | led edit-recipe-bundle | lhp | led launch
3. https://ci.chromium.org/swarming/task/5511eb3e8ef97310 (parent) and
   https://ci.chromium.org/swarming/task/5511eba8e2545410 (subbuild)
   both emit a "modified by led" step

Bug: 81568
Change-Id: I2b0c6bba9fb1c4338c97777dc3fb946f85c8e5fe
Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/prebuilt/+/562883
Reviewed-by: Anthony Fandrianto <atyfto@google.com>